duotone-syntax icon indicating copy to clipboard operation
duotone-syntax copied to clipboard

JSX style is unreadable and too dark

Open dbkaplun opened this issue 9 years ago • 9 comments

screen shot 2016-11-19 at 1 04 52 pm Code in question

dbkaplun avatar Nov 19 '16 21:11 dbkaplun

@dbkaplun Thanks for example code and screenshot.. that's very helpful.

Just another question: What's the language package you are using? I can see the grammar as `JavaScript (JSX).

simurai avatar Nov 22 '16 01:11 simurai

I'm using [email protected], is that what you mean? That's the only package I see when I search for "jsx" in the Packages tab of Settings. Maybe it's built-in?

dbkaplun avatar Nov 22 '16 04:11 dbkaplun

[email protected] shouldn't do syntax highlighting. Do you have https://atom.io/packages/language-babel. It has jsx support and is quite popular.

simurai avatar Nov 22 '16 05:11 simurai

I have package [email protected], maybe that's it? It's way too dark with .js as well. I'll attach a screenshot when I get the chance.

dbkaplun avatar Nov 22 '16 12:11 dbkaplun

Yes, react is probably it. I'll try it out with your sample code and see why it's so dark.

simurai avatar Nov 22 '16 12:11 simurai

Here's some nice dark JS code screen shot 2016-11-25 at 5 45 42 pm

dbkaplun avatar Nov 26 '16 01:11 dbkaplun

Ok, this should be improved with https://github.com/simurai/duotone-syntax/pull/21 and published as 2.0.1.

screen shot 2016-11-26 at 10 25 56 pm

simurai avatar Nov 26 '16 13:11 simurai

Definitely looks a little better, still very dark though (specifically punctuation and builtins like moveTo and Math.sin). Even linesCtx is very dark. It's a shame because this is my favorite theme and I hate having to use other themes. Should I open another issue? Looks like your Atom is significantly redder than mine.. on your screen, beginPath is white and on mine it's lavender. Maybe that has something to do with it? screen shot 2016-11-26 at 9 20 32 am

dbkaplun avatar Nov 26 '16 17:11 dbkaplun

Looks like your Atom is significantly redder than mine.. on your screen, beginPath is white and on mine it's lavender. Maybe that has something to do with it?

In DuoTone dark you can now change the colors in the settings, see: https://github.com/simurai/duotone-dark-syntax#settings So you could brighten everything.

I'll see about brightening the default since that seems a bit dark.

simurai avatar Nov 28 '16 08:11 simurai