immich-go icon indicating copy to clipboard operation
immich-go copied to clipboard

Adding --skip-problem-assets global param

Open coulterpeterson opened this issue 1 year ago • 1 comments

When performing large Google Photos uploads, I kept getting a halting "413 Request Entity Too Large" error, and excluding each file as it came up became too cumbersome, so this lets the user optionally skip those files, so they can go back and manually deal with them by referencing the log.

coulterpeterson avatar Mar 10 '25 16:03 coulterpeterson

Thank you for the PR.

A few remarks:

Since v0.24.2 there is the possibility to keep immich-go running after an error --on-server-errors. Why not using it?

  • The error message can improved as you propose.
  • The DeleteServer asset is a code remaining from the time where ReplaceAsset API wasn't implemented. I need to prune this code!
  • The error message enhancement can be done directly here 👇🏼 . You'd have to duplicate the code https://github.com/simulot/immich-go/blob/c80672b8ee09f5d3c2954378e6f4ea853e4aae82/immich/upload.go#L33-L108

simulot avatar Mar 10 '25 18:03 simulot