recurr icon indicating copy to clipboard operation
recurr copied to clipboard

Dates not meeting Constraints counting toward virtualLimit

Open omanizer opened this issue 9 years ago • 1 comments

Thanks so much for this fantastic library. It's been a pleasure to use.

The documentation states that

it is important to know that dates which do not meet the constraint's requirements do not count toward the transformer's virtual limit

however I have a test case that illustrates that dates outside of a constraint are counting toward this limit:

$rrule = 'dtstart=2015-01-20T00:00:05Z;freq=HOURLY;interval=1;byminute=23';
$ruleObj = new \Recurr\Rule($rrule);
$transformer = new \Recurr\Transformer\ArrayTransformer();
$constraint = new \Recurr\Transformer\Constraint\AfterConstraint(new \DateTime());
print_r($transformer->transform($ruleObj, $constraint));

This returns no results but according to the docs it should return 732 results since I specified a constraint. Is this correct?

Another test that illustrates this:

$rrule = 'dtstart=2016-01-20T00:00:05Z;freq=HOURLY;interval=1;byminute=23';
$ruleObj = new \Recurr\Rule($rrule);
$transformer = new \Recurr\Transformer\ArrayTransformer();
$constraint = new \Recurr\Transformer\Constraint\AfterConstraint(new \DateTime());
print_r($transformer->transform($ruleObj, $constraint));

This returns ~50 results when it should also return 732. When I manually specify a virtual limit of 10000 it returns thousands of results for both of these.

omanizer avatar Feb 17 '16 07:02 omanizer