sisyphus icon indicating copy to clipboard operation
sisyphus copied to clipboard

Added Id attribute to the prefix string.

Open gabrieljenik opened this issue 10 years ago • 3 comments

The prefix string is built so identifies uniquely each saved element This is usefull when having more than 1 element with the same name. (Ex. checkboxes with the same name)

gabrieljenik avatar Feb 24 '15 15:02 gabrieljenik

Thanks for the contribution! At a quick glance - it also introduces a bunch of unused variables, but I'll try take a closer look at it later.

simsalabim avatar Mar 06 '15 23:03 simsalabim

About unused variables: They are inside a method, for a more readable code. :)

gabrieljenik avatar Mar 07 '15 12:03 gabrieljenik

By method extract you left a bunch of variables unused in their original places. For example: https://github.com/gabrieljenik/sisyphus/blob/patch-2/sisyphus.js#L233

simsalabim avatar Mar 09 '15 19:03 simsalabim