Alexander Kaupanin

Results 27 comments of Alexander Kaupanin

I think this WYSIWYG editor is not supported yet. You can take a look how CKEditor is supported with the plugin and try implement it similar way. The plugin is...

@JangoSteve @rafaelfranca excuse me for my interruption guys, as I mentioned in [#339](https://github.com/rails/jquery-ujs/pull/339#issuecomment-26849139) jQuery's `data` already did the job and it treats `data-somewhat="false"` as [boolean](https://github.com/jquery/jquery/blob/master/src/data.js#L35) `false`. Using jQuery we admit...

@JangoSteve great, I did it exactly the way you described above. Is there any chance #339 will be merged then?

BTW, It could have been as simple as `if $(this).data('remote')` if only jQuery correctly treated HTML5 empty attributes. I sent a separate [patch](https://github.com/jquery/jquery/pull/1417) related to this issue. But that behavior...

As per discussion in jQuery issues I was pointed out that `data-*` attributes are not boolean in HTML5, thus case 1 `` is invalid. The question is, do you want...

@nWidart sorry, I can't contribute much to the original feature request but am open to seeing what you mean in a pull request. @thomas-preuss looks like [this](https://github.com/simsalabim/sisyphus/blob/master/sisyphus.js#L341-L343) is your answer,...

> I'd imagine most users would only expect the callbacks to fire if there are target elements to fire them on? What if a callback's logic has nothing to do...

Thanks a lot for the contribution! I am looking at the changes in [whitespace-ignoring mode](https://github.com/simsalabim/sisyphus/pull/111/files?w=1). Please follow the style guides and use tabs instead of spaces. Also, can you please...

@Ma3oBblu I like the intent of the PR but I can't merge it in this state: it has unresolved feedback and wasn't rebased off of master so GitHub doesn't allow...

Thanks for the contribution! At a quick glance - it also introduces a bunch of unused variables, but I'll try take a closer look at it later.