vue-clickaway icon indicating copy to clipboard operation
vue-clickaway copied to clipboard

Bugfix "Cannot read property 'context' of undefined` in update callback"

Open joshiste opened this issue 6 years ago • 16 comments

when update is called the vnode isn't passed and this results in an error. This commit fixes this. Would be glad if you would release this fix soon.

joshiste avatar Apr 25 '18 12:04 joshiste

The bug was introduced with bfc451706280a390e95f4b94cba424f72f300599

joshiste avatar Apr 25 '18 12:04 joshiste

@simplesmiler did you have a look on this one?

joshiste avatar Apr 30 '18 17:04 joshiste

🙏 Running into this myself!

jmduke avatar May 10 '18 20:05 jmduke

@simplesmiler is this project dead?

joshiste avatar Jun 08 '18 20:06 joshiste

having the same problem with nuxt

MarineLB avatar Jun 19 '18 17:06 MarineLB

Hello ! I have forked the project because i need this fix for my work. I will surely add your MR, so if you want, here it is :) : https://github.com/silverspectro/vue-clickaway

silverspectro avatar Jun 26 '18 16:06 silverspectro

@silverspectro will you publish on npmjs.org?

joshiste avatar Jun 26 '18 16:06 joshiste

sure, i can do that, but i can't use the same repo name as the first i think. So i don't know how to do that, as it would be cool to keep the same npm repo and just change the maintainers and github repo behind maybe ? @simplesmiler would it be ok for you ? Have you any intention to maintain this project further ? If not, i would be willing to do it (at least check the MR and do some code reviews). Do you have any ideas about this ?

silverspectro avatar Jun 28 '18 12:06 silverspectro

@silverspectro you could fork it and publish with a different name

joshiste avatar Jul 25 '18 20:07 joshiste

Hello!

Package published under a new very original name in npm: vue-clickaway2. Normally everything should work fine (tested on my project).

I did it a bit hastily so there may be some errors in the README or something still. Feel free to PR on it, I'll respond. Here is the new repo: https://github.com/silverspectro/vue-clickaway2

Hope it helps. Cheers,

silverspectro avatar Aug 15 '18 11:08 silverspectro

I know this is a old thread, but I wanted to thank @joshiste and @silverspectro for doing this. Was running into a very specific bug, using clickaway with svgicon and the new repo fixed it perfectly.

Thank you very much.

espindolaa avatar Jan 30 '19 13:01 espindolaa

Any news about this PR @simplesmiler ? That would be great to avoid multiply forks !

Prechan avatar May 21 '19 16:05 Prechan

Ran into this issue today and can confirm that vue-clickaway2 works properly. Thanks @silverspectro <3

TPXP avatar Sep 20 '20 15:09 TPXP

Just changed to vue-clickaway2 in our project due to this bug. Thanks a log for forking and publishing as a separate package!

iampava avatar Nov 02 '20 11:11 iampava

@simplesmiler can you merge this in and redeploy to npm? If you need a new maintainer for the library, let me know.

nVitius avatar Jan 18 '21 23:01 nVitius

I am also experiencing this on bind.

image

ronssij avatar Jun 23 '22 04:06 ronssij