simplesamlphp icon indicating copy to clipboard operation
simplesamlphp copied to clipboard

Now allowing Authsources to set validUntil and cacheDuration for Metadata.

Open tommy2d opened this issue 4 years ago • 4 comments
trafficstars

Now allowing generation of SP metadata XML that includes @validuntil or @cacheDuration at EntityDescriptor.

tommy2d avatar Jul 12 '21 10:07 tommy2d

Codecov Report

Merging #1481 (3defd30) into master (31a49a8) will increase coverage by 0.00%. The diff coverage is 60.00%.

@@            Coverage Diff            @@
##             master    #1481   +/-   ##
=========================================
  Coverage     40.05%   40.05%           
- Complexity     3531     3532    +1     
=========================================
  Files           141      141           
  Lines         10596    10598    +2     
=========================================
+ Hits           4244     4245    +1     
- Misses         6352     6353    +1     

codecov[bot] avatar Aug 27 '21 19:08 codecov[bot]

I've rebased against master because the PR targeted the 1.19-branch and this is not something we can merge there. I've made a backup of the branch before I did. @thijskh : Do you agree that the expire-setting has now become obsolete and should go?

tvdijen avatar Aug 27 '21 19:08 tvdijen

There's still quite a lot of code that refers to expire when talking about remote entities I think. Are you referring to that or to the setting for hosted entities (does that exist?).

thijskh avatar Sep 04 '21 19:09 thijskh

It does not exist for hosted entities I think, so for remote entities... validUntil is translated to the expire setting by our metadata converter and I think it makes sense to rename it to validUntil.. We have to update the metarefresh-module as well if we do so

tvdijen avatar Sep 04 '21 19:09 tvdijen