SimpleInjector icon indicating copy to clipboard operation
SimpleInjector copied to clipboard

Source link support

Open davidroth opened this issue 3 years ago • 2 comments

Source link is a great feature enabling easy and frictionless debugging of nuget packages. I'd love to have source link support in SimpleInjetor. This would make it very easy to step into SimpleInjector`s source code to understand runtime behavior or to investigate potential bugs.

I recently integrated source link in our own OSS project. I am happy to support you if you have any issues. Or I could just prepare a pull request if you dont have the time. Just let me know ;-)

davidroth avatar Jan 13 '21 13:01 davidroth

This is an interesting idea that has crossed my mind multiple times in the past, but never got further than that because I didn't find it that interesting to invest my time on.

That said, I am very interested to understand more about it, and a PR would certainly be useful. Especially because it gives me a sense of what the consequences are of doing this from a maintainability perspective. Remember: even code written by others typically need to be maintained by me, so that means I'm always careful in adding new features.

This means that I can't guarantee you that I'd accept your PR, but I certainly would like to see it.

dotnetjunkie avatar Jan 13 '21 13:01 dotnetjunkie

Impact is minimal. Its mostly a csproj/build.props thing. I'll prepare a PR and we can discuss the details there.

davidroth avatar Jan 13 '21 13:01 davidroth