SimpleIdServer icon indicating copy to clipboard operation
SimpleIdServer copied to clipboard

[SCIM] ResourceTypes endpoint response

Open gabrielemilan opened this issue 2 years ago • 6 comments

Hello, is it possibile to change the response of the ResourceTypes endpoint?

This is the current response:

image

But following the RFC (https://datatracker.ietf.org/doc/html/rfc7643#section-8.6) it should be:

image

And also I think that is necessary to put the paging properties:

image

https://developer.4me.com/v1/scim/resource_types/

Thanks. Gabriele

gabrielemilan avatar Jan 27 '22 12:01 gabrielemilan

Hello,

There is an issue in the current implementation. I'm going to work on it.

Kind Regards,

SimpleIdServer

simpleidserver avatar Jan 28 '22 10:01 simpleidserver

This small issue has been fixed in the branch "release/2.0.5".

Kind Regards,

SimpleIdServer

simpleidserver avatar Jan 28 '22 12:01 simpleidserver

Hello, tried new version, now the endpoint returns: image

I think that the id and the location should be singular, the only plural should be the endpoint, isn't it?

gabrielemilan avatar Jan 28 '22 14:01 gabrielemilan

Indeed the "id" & "location" parameters must be singular. The following changes have been made in the branch "release/2.0.5" :

  • Add a new endpoint "/ResourceTypes/{id}"
  • Location & Id parameters are now singular.

Kind Regards,

SimpleIdServer

simpleidserver avatar Jan 28 '22 14:01 simpleidserver

Hello,

I tried the new version and it seems there is another issue. The ResourceType should be singular:

image

https://datatracker.ietf.org/doc/html/rfc7644#section-3.3.1

image

In the previous version it was singular.

Thanks. G

gabrielemilan avatar Feb 02 '22 12:02 gabrielemilan

Hello,

The tables "SCIMRepresentationLst", "SCIMSchemaLst", "SCIMAttributeMapping" don't have a valid "ResourceType" value. This property contains a "s" character at the end and it should be removed. Please execute this SQL script to remove the "s" character : https://github.com/simpleidserver/SimpleIdServer/blob/release/2.0.5/Migrations/SCIM/2.0.4To2.0.5/1-RemoveSFromResourceType.sql

Some changes have been made in the branch "release/2.0.5" to fix the issue.

Kind Regards,

SimpleIdServer

simpleidserver avatar Feb 02 '22 14:02 simpleidserver