simplecov icon indicating copy to clipboard operation
simplecov copied to clipboard

Monotonic time

Open pboling opened this issue 9 months ago • 2 comments

Important background: Monotonic time is the "correct" way to calculate elapsed time in Ruby: https://blog.dnsimple.com/2018/03/elapsed-time-with-ruby-the-right-way/

  • [x] Adds started_at based on the monotonic clock which is guaranteed to always move forward (processor uptime)
  • [x] Fixes created_at / timestamp based on Process.clock_gettime(Process::CLOCK_REALTIME), to avoid Time.now stubbing & Timecop issues
  • [x] Fixes #559 (I think)
  • [x] Fixes #815 (I think)
  • [x] Fixes some spec failures in the cucumber suite, due to a bug in Rails, where it failed to require "logger".
  • [x] Fixes an out of order condition which results in incompability with turbo_tests - an "almost drop-in" replacement/enhancement of parallel_tests) (see: https://github.com/serpapi/turbo_tests/issues/24) (though there are other major blockers preventing compatibility with turbo_tests)

I do not understand the rubocop failure in CI, because when I run locally there are no violations:

❯ bundle exec rubocop -a
Inspecting 111 files
...............................................................................................................

111 files inspected, no offenses detected

Same result when run with bundle exec rake rubocop as it is in CI.

CC @ilyazub

pboling avatar Mar 07 '25 01:03 pboling

This is now ready for review @amatsuda @PragTob

pboling avatar Mar 07 '25 18:03 pboling

Note: the rubocop failure will be fixed once @simi's work in #1131 is merged, and thus it will be a completely green build! Ping @amatsuda @PragTob.

pboling avatar Jun 13 '25 15:06 pboling