roadmap icon indicating copy to clipboard operation
roadmap copied to clipboard

Time zone selector is wrong when current time zone is not part of the list

Open adriaandotcom opened this issue 4 years ago • 7 comments

When I go to https://simpleanalytics.com/example.com/settings on desktop (e.g. Firefox) I see the following:

[ ] UTC [X] Europe/Berlin [ ] Other time zone (collapsed)

However, when I go to that page on mobile (e.g. Firefox), I see the following:

[ ] UTC [ ] CET [X] Other time zone (expanded) - GMT -12:00

What browser are you using on mobile vs desktop?

On desktop I used Firefox (for Linux), where it was correct, and on mobile I used Firefox for Android, where it was wrong.

adriaandotcom avatar Apr 05 '20 19:04 adriaandotcom

If you could check this one @hellodeibu

adriaandotcom avatar Apr 06 '20 08:04 adriaandotcom

Customer:

If you're using Intl.DateTimeFormat().resolvedOptions().timeZone in JavaScript to detect the time zone name, the above expression returns "Europe/Berlin" for me on Firefox for Linux but "CET" on Firefox for Android.

This looks like a bug in Firefox for Android, for which there's already an issue in Mozilla's bug tracker: https://bugzilla.mozilla.org/show_bug.cgi?id=1609714 Hopefully this gets fixed soon.

adriaandotcom avatar Apr 06 '20 09:04 adriaandotcom

@adriaanvanrossum given that the bug is in Firefox (and on Android only, seemingly), known and their PR will eventually be merged into their main release channel, do you think it'll still be good to look for a way to see if we can work around this issue on our end too? As it's such a specific use-case that most customers won't run into, and even if they do is a mild inconvenience as no functionality actually breaks. If you like I could see if there's something we can do on our end of course, I just wanted to double check this before I do.

jibsaramnim avatar Apr 10 '20 07:04 jibsaramnim

I agree. Let's focus on other issues for now and but let's keep this open to check back in 2 months if Firefox did fix it. Added a reminder to my list.

adriaandotcom avatar Apr 10 '20 09:04 adriaandotcom

They updated their issue to make it a duplicate of https://bugzilla.mozilla.org/show_bug.cgi?id=1534160. We can check the progress of this PR, it seems done, but not reviewed yet.

https://github.com/unicode-org/icu/pull/605. There is some movement in that PR in the recent days. Let's wait one more month.

adriaandotcom avatar Jun 10 '20 13:06 adriaandotcom

They updated their issue to make it a duplicate of https://bugzilla.mozilla.org/show_bug.cgi?id=1534160. We can check the progress of this PR, it seems done, but not reviewed yet.

unicode-org/icu#605. There is some movement in that PR in the recent days. Let's wait one more month.

@adriaanvanrossum merged.

srl295 avatar Jul 06 '20 17:07 srl295

Thanks for letting us know @srl295, appreciate it.

adriaandotcom avatar Jul 07 '20 12:07 adriaandotcom