simple-salesforce icon indicating copy to clipboard operation
simple-salesforce copied to clipboard

full_domain argument to constructors

Open madeleineth opened this issue 5 years ago • 2 comments

This lets you log in on domains other than ones ending in ".salesforce.com".

Also drop a redundant test, test_custom_session_success, which runs the same code as test_default_domain_success.

Close https://github.com/simple-salesforce/simple-salesforce/issues/351.

I have tested this locally with tox and against a Salesforce sandbox with a non-salesforce.com domain.

madeleineth avatar Dec 13 '20 21:12 madeleineth

This looks neat!

brno32 avatar May 01 '21 11:05 brno32

This PR has been sitting here for a while, so I rebased onto master, re-ran the tests, and fixed a resource-deallocation issue elsewhere in the package. I've been running my fork as part of a deployed application for a few months now.

madeleineth avatar May 09 '21 20:05 madeleineth