browser-extension icon indicating copy to clipboard operation
browser-extension copied to clipboard

Add Dark and System themes

Open ilyapopovs opened this issue 2 years ago • 1 comments

Add Dark and System themes. System theme switches between Light and Dark based on prefers-color-scheme media feature.

Changes sum-up:

  • add new Settings entry
  • replace hard-coded CSS colors with CSS Variables (except ones that can stay the same)
  • switch CSS Variable values based on the parent class
  • add the according class to body

ilyapopovs avatar Oct 18 '22 23:10 ilyapopovs

Tested on: Firefox 105.0.3 ✅ Chrome 106.0.5249.119 ✅

But I might have missed some small part of the UI. Would be nice if someone else could validate as well :)

ilyapopovs avatar Oct 18 '22 23:10 ilyapopovs

@ilyapopovs thanks for making the PR and sorry for the late reply! I tested the PR and it works well. Our developers are currently reviewing the code and will make sure to come back to you quickly!

nguyenkims avatar Oct 24 '22 15:10 nguyenkims

@ilyapopovs Looks good to me 👍🏻 I've pushed a commit on your PR moving every theme utilities into a single place.

edvincandon avatar Oct 25 '22 09:10 edvincandon

@edvincandon Changes look good to me 👍

Let me know if anything else is needed from my side to move this forward :)

ilyapopovs avatar Oct 25 '22 19:10 ilyapopovs

Glad to help! 🙂

Also, Issue https://github.com/simple-login/browser-extension/issues/118 can be closed

ilyapopovs avatar Oct 31 '22 22:10 ilyapopovs

@ilyapopovs we are going to make a release for this version and will announce it on our social media. If that works for you, we'd like to mention you in these posts as this feature is highly requested and it only becomes available thanks to your contribution. In this case please send me your social media handle. SL is active on Twitter, Reddit and Linkedin. cc @aIext

nguyenkims avatar Nov 02 '22 22:11 nguyenkims

@nguyenkims sure! I'm not particularly active on Twitter or Reddit, but it's @ilyapopovs on those 3.

ilyapopovs avatar Nov 06 '22 05:11 ilyapopovs