Include website address does not work anymore after updating alias settings

[Heziode]

Please note that this is only for bug report.

For help on your account, please reach out to us at hi[at]simplelogin.io. Please make sure to check out our FAQ that contains frequently asked questions.

For feature request, you can use our forum.

For self-hosted question/issue, please ask in self-hosted forum

Prerequisites

• [X] I have searched open and closed issues to make sure that the bug has not yet been reported.

Bug report

Describe the bug When I do some modifications in Aliases section, the Include website address feature does not work anymore. Even if I disable > update > enable > update it.

By does not work, I mean it generate aliases based on Aliases settings, without taking account the Include website address.

Expected behavior

The feature Include website address should work (or be automatically disabled) when we edit Aliases parameters.

Screenshots If applicable, add screenshots to help explain your problem.

Additional context My version of the backend is based on 67dad33b700d86c9364092f8efa32fe289fcc5e0 (like the current app.simplelogin/git)

[nguyenkims]

I tried to reproduce the issue following these steps but can't, let me know if I'm missing something:

• select my custom domain as default domain for aliases
• disable the "Include website address in one-click alias creation on browser extension" setting
• click a new alias via the browser extension by right clicking on "Create random alias": the alias doesn't have the website name
• enable the "Include website address in one-click alias creation on browser extension" setting
• click a new alias via the browser extension by right clicking on "Create random alias": the alias has the website name

[Heziode]

The problem does not came from the Popup, but from the added button in forms, like in the following screenshot:

If I click on the button of the following screenshot, it generate an alias with the website address:

However, if I use the button in a form (first screenshot), it generate a complete random alias.

[nguyenkims]

Yes this second button indeed always generate a random alias. It's a bit confusing and we might remove it in the next version.

[Heziode]

So, for the button added in form, it should act like the Create button of the popup of the extension, isn’t?

Because this is not the case, since it does not generate an email based on the domain name (like explained in the first post)

[nguyenkims]

I'm not sure to totally understand. Currently there are 3 ways to create an alias via the browser extension:

• clicking on the icon injected in the email field: the new alias uses the website domain if the setting is enabled (it's enabled by default) and the default domain if set.
• right click: create the same alias as clicking on the icon
• click on "OR create a totally random alias": create a total random alias, not using the website domain or default domain. Will probably removed in the next version.

[Heziode]

clicking on the icon injected in the email field: the new alias uses the website domain if the setting is enabled (it's enabled by default) and the default domain if set.

I mean this one. The behavior is weird. When I test this button on Facebook it generates an alias based on the website domain, however, if I attempt to generate an alias with this button on just-eat, it generates a random alias.

[nguyenkims]

@Heziode I went to https://www.just-eat.fr/ and the proposed alias starts indeed with just-eat, I wonder if your setting has maybe changed in the meantime?

[Heziode]

@nguyenkims,

Here is a short video of the issue:

https://user-images.githubusercontent.com/16735076/169049298-0fb852c0-5aec-4daf-80dc-eab211acb272.mp4

[nguyenkims]

@Heziode thanks. I wonder if this alias has been used before on that website? Because in this case clicking on SL icon will return this same alias.

[Heziode]

Nope, this alias as not been used before. Every time I click on the button, it generates a new random alias.

[nguyenkims]

@Heziode can you send a screencast of what happens on Facebook? I don't have any clue for now why the domain is included for facebook.com but not https://www.just-eat.fr/ on your account.

[Heziode]

In fact, it doesn't even work on Facebook:

https://user-images.githubusercontent.com/16735076/169282668-0e5cb51a-75ea-469b-8463-688d98b81455.mp4

My hypothesis is that somewhere, when we do change in settings of alias (« Change the way random aliases are generated by default. », « Select the default suffix generator for aliases. »), it shortcuts the « Include website address in one-click alias creation on browser extension » or change a priority over which « rule » to apply to the local part generation (I haven't looked at the code, so I don't know how it works)

[nguyenkims]

I wonder if this can be due to the browser extension cannot extract the domain name from the tab? Can you try on another browser?

[Heziode]

Exactly the same issue using a fresh new FireFox install (tested on Facebook).

[nguyenkims]

We have released the new version 2.6.3 on Firefox, I'd suggest to give this version a try. For now I don't have any idea about what can cause the issue you exprienced.

[Heziode]

Same issue with 2.6.3 on FireFox.

Is the order / priority of the generation of the local part is saved into the database? Maybe an issue on this side

[nguyenkims]

@Heziode every call is different (not cached) so I don't think it's the case. Can you please create a new account with SL and retry? Thanks for your help!

[Heziode]

I didn't forget, I'm busy, I do the test when I have a moment.

[Heziode]

@nguyenkims So, after created a new account, there is no issues, Strange… I don't know how I can fix this with the current SL account.

[nguyenkims]

@Heziode the only option that can affect this setting is on https://app.simplelogin.io/dashboard/setting#include_website_in_one_click_alias