sls icon indicating copy to clipboard operation
sls copied to clipboard

Does not submit recording MBID to ListenBrainz

Open phw opened this issue 7 years ago • 8 comments

SLS does not seem to submit the recording MBID to ListenBrainz.

There is actually code for this at https://github.com/tgwizard/sls/blob/2e79b0a3c05c59d2f1b0e13898c93bb736f1fbf1/app/src/main/java/com/adam/aslfms/service/Scrobbler.java#L256 which is looking good, but disabled. What's the reason?

phw avatar Feb 07 '18 13:02 phw

Was added and commented out in: https://github.com/tgwizard/sls/commit/d7ab95f7bbaa6f654ab5c7147c3198e13feaed8f

inverse avatar Feb 07 '18 13:02 inverse

First of all, great project - so glad to see LB finally being supported. Yes, please could we uncomment this? There is not much point scrobbling to Listenbrainz without submitting the recording_mbid. This is the key that links the scrobbled track to the database and thus to all the other track info. Without this the only info you have is the track name and the artist which gives issues e.g. there is no way to distinguish between tracks with the same name by the same artist. One other advantage of submitting recording_mbid is that in the Listenbrainz UI you actually get a clickable link on your "listen" to the Musicbrainz entry, ditto with artist_mbids and release_mbid (makes sense to send all of them). Thanks!

ojsquire avatar Apr 02 '18 11:04 ojsquire

Too bad there is no one to handle this. Random person cannot put the update to Play Store.

youk avatar Jul 01 '18 21:07 youk

I'm really glad that SLS supports ListenBrainz!

Can anyone please merge the PR?

regagain avatar Dec 24 '18 20:12 regagain

I fixed the code manually for the next build.

a-r-db avatar Jun 24 '19 11:06 a-r-db

Not many apps support MBID anyways. It's worth a try though. Maybe a few open source apps do. Or Google Play unique music apps.

a-r-db avatar Jun 24 '19 11:06 a-r-db

Not many apps support MBID anyways. It's worth a try though. Maybe a few open source apps do. Or Google Play unique music apps.

Maybe someday in BubbleUPnP – https://forum.xda-developers.com/showpost.php?p=80258133&postcount=15049

youk avatar Sep 26 '19 06:09 youk

can't get smoralis mr to work, but I'm not a java dev... anyone interested ? Tried some debug here : https://community.metabrainz.org/t/android-player-mbid-submission-support/446353/13

petitminion avatar May 13 '21 09:05 petitminion