simple-icons icon indicating copy to clipboard operation
simple-icons copied to clipboard

Published 20 hours ago • verified publisher icon simple-icons

Request: Fueler

Open namrata18s opened this issue 1 year ago • 9 comments

Issue: closes #9977 Similarweb rank:

Checklist

  • [x] I updated the JSON data in _data/simple-icons.json
  • [x] I optimized the icon with SVGO or SVGOMG
  • [x] The SVG viewbox is 0 0 24 24

Description

Colour from website stylesheet.

Steps taken to process .svg (expand)

I took the logo from website-header I used Inkspace for processing: resized canvas appropriately, updating the viewport to 0 0 24 24 resized content appropriately centered content horizontally and vertically converted to monochromatic I exported from Inkscape with the option 'optimised .svg' I used npx svgo to further optimise I annotated the file I ran the lint task to check for errors -> icon-size and icon-centered I adjusted the logo accurately to the canvas for icon-size I used npx svgo -p 2 and re-ran lint task -> lint succeeded

namrata18s avatar Dec 04 '23 08:12 namrata18s

hi @PratyushJayachandran , I have updated the svg file could you please take a look into it .

namrata18s avatar Dec 08 '23 01:12 namrata18s

@PratyushJayachandran Did you get a chance to look at fueler svg . Does it have still same issue?

namrata18s avatar Dec 09 '23 16:12 namrata18s

@PratyushJayachandran Did you get a chance to look at fueler svg . Does it have still same issue?

I'll do by next week

PratyushJayachandran avatar Dec 09 '23 17:12 PratyushJayachandran

Hi @PeterShaggyNoble, you mean setting the precision to 1 while running the SVGO? I was wondering wouldn't the lint run fail in this case?

namrata18s avatar Dec 11 '23 11:12 namrata18s

No, our icons can have a maximum precision of 5 decimal places, so you can try increasing by 1 place in your optimisation process until you get to a point where you can't see a difference between your version and the original. Without trying it myself, I'd say this one will need a precision of 3, but we might get away with 2.

PeterShaggyNoble avatar Dec 11 '23 12:12 PeterShaggyNoble

@PratyushJayachandran Did you get a chance to look at fueler svg . Does it have still same issue?

As @PeterShaggyNoble mentioned the contributed icon is not retaining the dimension ratio of the original icon. Please scale proportionally. Only one of the dimensions(vertical in this case) needs to be 24px.

See comparison here

PratyushJayachandran avatar Dec 18 '23 09:12 PratyushJayachandran

Are you still working on this one, @namrata18s?

PeterShaggyNoble avatar Jan 11 '24 15:01 PeterShaggyNoble

@adamrusted, which file did you base your version on? I'm seeing quite a few differences when comparing it with the one in the header.

EDIT: Seeing the same differences when comparing with the logo in the footer; here's an example, with yours in red.

PeterShaggyNoble avatar Feb 12 '24 11:02 PeterShaggyNoble

I'm must be looking at the wrong source file. When I resize the one in the header to 24dp in height, it's coming in at 23.04dp in width, whereas Adam's is 23.05 wide 🤔

PeterShaggyNoble avatar Feb 15 '24 12:02 PeterShaggyNoble