simpeg icon indicating copy to clipboard operation
simpeg copied to clipboard

Remove code duplication for time and frequency stitched

Open domfournier opened this issue 2 years ago • 1 comments

Proposed changes to PR #1300 to reduce code duplication and complexity.

Main changes:

1- Consolidate the methods of time and frequency Simulation1DLayeredStitched onto base class. 2- Storage of Hankel coefficients in dataclass container 3- Storage of Cole-Cole parameters in dataclass container 4- Review of new regularization and mesh class (to be continued)

domfournier avatar Dec 30 '23 16:12 domfournier

Codecov Report

Attention: 467 lines in your changes are missing coverage. Please review.

Comparison is base (3d7666f) 80.32% compared to head (7d8c893) 81.39%. Report is 25 commits behind head on em1d_stitched_update.

Files Patch % Lines
SimPEG/electromagnetics/utils/em1d_utils.py 24.24% 175 Missing :warning:
...mPEG/regularization/regularization_mesh_lateral.py 36.51% 113 Missing :warning:
SimPEG/electromagnetics/base_1d_stitched.py 71.75% 87 Missing :warning:
SimPEG/regularization/laterally_constrained.py 0.00% 47 Missing :warning:
...imPEG/potential_fields/gravity/_numba_functions.py 32.55% 29 Missing :warning:
SimPEG/electromagnetics/base_1d.py 92.04% 7 Missing :warning:
SimPEG/potential_fields/gravity/simulation.py 94.05% 6 Missing :warning:
SimPEG/regularization/base.py 80.00% 2 Missing :warning:
...mPEG/electromagnetics/time_domain/simulation_1d.py 97.61% 1 Missing :warning:
Additional details and impacted files
@@                   Coverage Diff                    @@
##           em1d_stitched_update    #1314      +/-   ##
========================================================
+ Coverage                 80.32%   81.39%   +1.07%     
========================================================
  Files                       164      170       +6     
  Lines                     25099    26094     +995     
========================================================
+ Hits                      20161    21240    +1079     
+ Misses                     4938     4854      -84     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 30 '23 20:12 codecov[bot]