discretize icon indicating copy to clipboard operation
discretize copied to clipboard

Published 20 hours ago • verified publisher icon simpeg

inner product names

Open lheagy opened this issue 8 years ago • 4 comments

  • getEdgeInnerProduct --> edgeInnerProduct
  • getFaceInnerProduct --> faceInnerProduct

thoughts @rowanc1 ?

lheagy avatar Mar 30 '17 00:03 lheagy

That sounds fine.

I would like to deal with this in a PEP8 blitz as well. #39. So _s are probably better.

rowanc1 avatar Mar 30 '17 14:03 rowanc1

Do they take any input arguments? If not, converting them to @property would be nice to get rid of the ()

leouieda avatar Mar 30 '17 19:03 leouieda

These ones do take inputs, yes, they are dependent on the physical property:

MeSigma = mesh.getEdgeInnerProduct(sigma, invertMatrix=True)

rowanc1 avatar Mar 30 '17 20:03 rowanc1

Right, that makes sense.

leouieda avatar Mar 30 '17 20:03 leouieda

handled in the pep8 rename a while ago

jcapriot avatar Mar 14 '23 21:03 jcapriot