markdown-viewer icon indicating copy to clipboard operation
markdown-viewer copied to clipboard

Feature: Support the "on click" permission option

Open jsejcksn opened this issue 5 years ago • 7 comments

and include the option just for file-property matching in the options view. This will add an option for users who have need for increased security to be able to use the extension.

on-click

jsejcksn avatar Mar 10 '19 03:03 jsejcksn

See Install and manage extensions > Let extensions read and change site data

on https://support.google.com/chrome_webstore/answer/2664769

jsejcksn avatar Mar 10 '19 03:03 jsejcksn

TBH I'm not even sure how exactly these new options in Chrome works. They all seem a bit wonky to me. What this extension is doing, however, long before anyone though about this issue is actually allowing you to choose your origins.

The On click option was introduced by Google to allow the users to limit the extensions that require access to all origins during install time. Markdown Viewer is clearly not such extension, and allowing access to all origins was never encouraged, because it's simply not needed, but again - it's up to you.

simov avatar Mar 10 '19 08:03 simov

This isn't going to be implemented, but thanks for the feedback. Also, checkout Markdown Viewer v5 that just got released.

simov avatar Dec 10 '22 18:12 simov

This isn't going to be implemented, but thanks for the feedback.

@simov Thanks for the message! You're the code owner, so this is of course your decision. Would you like to offer any insight into why you don't want to empower users with this security/privacy choice?

jsejcksn avatar Dec 10 '22 18:12 jsejcksn

Actually immediately after I closed this one, as I'm doing a cleanup I realized that this may be a viable feature request. So I will be reopening this one, I will have to think about it.

simov avatar Dec 10 '22 18:12 simov

Honestly, I have no idea how this could be implemented on top of my head .. Generally speaking Markdown Viewer was never designed to work that way, which isn't to say that it won't be possible.

simov avatar Dec 10 '22 18:12 simov

But note that Markdown Viewer v5 is also using the latest manifest v3 which is supposed to be much more secure, at least that's how they are promoting it.

simov avatar Dec 10 '22 18:12 simov