markdown-viewer icon indicating copy to clipboard operation
markdown-viewer copied to clipboard

Violated github-flavoured-markdown footnotes rules for displaying

Open jerrygreen opened this issue 2 years ago • 1 comments

What the extension does emit:

image

Actual footnotes in github flavored markdown[^1][^2]:

image

The extension violates these rules:

  1. Square brackets [ and ], near the link to a footnote, should be emitted. It looks more recognizable and easier to click.
  2. Text ids [^note] should translate into a number. That is common for footnotes (ever seen the else case, say, on wiki?).
  3. There should be a humble text symbol. Not an ugly "↩" emoji.
  4. Footnotes should be smaller than normal text, and grayed out.

Last but not least:

  1. github-flavoured-markdown has an accurate 1px of line separator for footnotes. Not some default browser's 4px[^3].

Just in case, my compiler options (gfm enabled):

image

P.S. I know this might be related to how "remark" package library renders, not to the extension. But I can't be sure where's the problem, gotta file it somewhere.

[^1]: Basic writing and formatting syntax - GitHub Docs [^2]: Footnotes now supported in Markdown fields - GitHub Changelog [^3]: Technically, Github, too, has some default 4px line for hr tag, but they don't use it, and instead they use border-top: 1px solid var(--color-border-default) css property, - for footnotes, and literally everywhere in their UI. Honestly I think they should change hr to an accurate 1px, too, - but that is less related to the issue.

jerrygreen avatar Feb 26 '22 14:02 jerrygreen

Oh, just forgot:

  1. By clicking on a footnote-link, the footnote gets selected also:

image

jerrygreen avatar Feb 26 '22 15:02 jerrygreen

Seems like all of your concerns got fixed in the latest Remark version. Make sure you have the latest Markdown Viewer v5 that got released a few days ago. It is available on the Chrome Web Store and here in the releases section.

simov avatar Dec 11 '22 17:12 simov