shot-scraper Make --timeout option consistent across all commands (including javascript)

Make --timeout option consistent across all commands (including javascript)

Open beetleb opened this issue 1 year ago • 2 comments

Currently the javascript command doesn't support a timeout option.

(Wider context: I'm trying to use Readability as you described here).

Sep 09 '23 00:09 beetleb

Huh, right now the sub-commands shot and multi and accessibility have the --timeout option but javascript and html and pdf do not.

Mar 09 '24 19:03 simonw

It's used like this: https://github.com/simonw/shot-scraper/blob/0268b0ccdb42e08738d840bb77484f2e60cdbd7f/shot_scraper/cli.py#L432-L434

So it needs to be passed like this:

https://github.com/simonw/shot-scraper/blob/0268b0ccdb42e08738d840bb77484f2e60cdbd7f/shot_scraper/cli.py#L520-L532

Mar 09 '24 19:03 simonw