llm icon indicating copy to clipboard operation
llm copied to clipboard

Dataclasses missing from the advanced model plugins page in live

Open simonw opened this issue 6 months ago • 5 comments

https://llm.datasette.io/en/stable/plugins/advanced-model-plugins.html#supporting-tools

Image

In my local dev environment it looks like this:

Image

simonw avatar May 30 '25 05:05 simonw

Relevant code:

https://github.com/simonw/llm/blob/2fd6c09db1d09a28fb93a35526cb37cdf7430143/docs/plugins/advanced-model-plugins.md#L141-L149

simonw avatar May 30 '25 05:05 simonw

Added in this commit: https://github.com/simonw/llm/commit/218bd10d6d469b8c8a0305c5e2f048cab218d74b

I think this is the problem: https://github.com/simonw/llm/blob/218bd10d6d469b8c8a0305c5e2f048cab218d74b/docs/conf.py#L37

But that should be installed already? I don't think it needs to be added to requirements.

simonw avatar May 30 '25 05:05 simonw

Oh maybe it's the path that Python is running on when it runs the Sphinx commands? In RTD it may not have my llm stuff installed and available.

simonw avatar May 30 '25 05:05 simonw

That fixed it on /en/latest/: https://llm.datasette.io/en/latest/plugins/advanced-model-plugins.html#supporting-tools

I'm going to !stable-docs to deploy it to live.

simonw avatar May 30 '25 05:05 simonw

Ugh that didn't fix it on the stable branch at all, because I didn't cause the .readthedocs.yml to update in that branch... and I accidentally deployed this section there too which isn't in a release yet: https://llm.datasette.io/en/latest/plugins/advanced-model-plugins.html#tracking-resolved-model-names

I think I can fix that by editing the stable branch directly.

simonw avatar May 30 '25 05:05 simonw

Fixed:

Image

simonw avatar Aug 12 '25 05:08 simonw