llm icon indicating copy to clipboard operation
llm copied to clipboard

Upgrade tests for compatibility with Click 8.2.0

Open simonw opened this issue 6 months ago • 2 comments

https://click.palletsprojects.com/en/stable/changes/#version-8-2-0

It broke some stuff in our tests:

  • https://github.com/simonw/llm/pull/996#issuecomment-2878203692

I'm going to pin to Click earlier than that just in our tests just for the sake of shipping my new alpha, then revisit later.

simonw avatar May 13 '25 23:05 simonw

Relevant from the Click changelog:

Keep stdout and stderr streams independent in CliRunner. Always collect stderr output and never raise an exception. Add a new output stream to simulate what the user sees in its terminal. Removes the mix_stderr parameter in CliRunner. #2522 #2523

simonw avatar May 13 '25 23:05 simonw

Note that Click dropped support for Python 3.9 early - it's EOL in October:

  • https://github.com/pallets/click/pull/2893

My policy is to support until the EOL date. That's fine if Click still works - my CI will catch that.

simonw avatar May 13 '25 23:05 simonw