csv-diff icon indicating copy to clipboard operation
csv-diff copied to clipboard

fix comparing of csv files with non-default file encoding

Open mikecoop83 opened this issue 3 years ago • 2 comments

When using the CLI to compare two CSVs that were encoded using cp1252 on a platform with a default encoding of utf-8, it fails. Since the encoding is not specified when opening the files, the default encoding is used and fails for any byte sequences that are not valid utf-8. This looks like it would resolve #14. The fix in this PR is to allow the user to specify the encoding of the file as a command line option.

mikecoop83 avatar Apr 07 '21 03:04 mikecoop83

@simonw - any thoughts on this?

mikecoop83 avatar May 24 '21 02:05 mikecoop83

I would really like to have this feature merged in. The text Im comparing isnt always utf-8.

danasmoot avatar Jan 10 '24 17:01 danasmoot