Christian Simon

Results 147 issues of Christian Simon

## Feature Request ### Summary Add the ability to group profiling samples by more granular code location attributes, specifically: - Absolute line number within a file - Relative line number...

While our helm chart uses a fairly old version of minio anyhow, we likely want to move on from minio, given they stopped providing helm charts and docker images for...

good first issue
helm

Since https://github.com/open-telemetry/opentelemetry-ebpf-profiler/pull/651 the ebpf profiler allows to track uprobe events, we should add a test to the OTLP convered that we correctly handle this profile type. https://github.com/open-telemetry/opentelemetry-ebpf-profiler/blob/161d3ffd410f17005a2c65679e855ebdfc7fda87/reporter/internal/pdata/generate.go#L149-L151

I have seen a couple of problems when looking into #4472 - ReadRows not used correctly (in tests, maybe code base), io.EOF not handled. - Problems around parquet.Group, might need...

The helm chart should validate esp. options belonging to the `architecture.` prefix. Added by #4417 - Are both v1 and v2 disabled? - Are ingesterWeight and segmentWriterWeight correct?

When serving queries from bucket store-gateways open blocks, but they are never closed: https://github.com/grafana/pyroscope/blob/0f7587769d9aee15579ea4d40ff19ca634f15b2c/pkg/storegateway/query.go#L199 We should implement reference counting and also define a block idle time.: https://github.com/grafana/pyroscope/blob/0f7587769d9aee15579ea4d40ff19ca634f15b2c/pkg/phlaredb/block_querier.go#L2083-L2094 Reported via the...

#### Is your feature request related to a problem? Please describe. Our current implementation of source integration only support Go source code that is directly in the git repo or...

enhancement

The flamebearer metadata passes the sample rate to the frontend: https://github.com/grafana/pyroscope/blob/9bc2847e6b2e24a09f85b3511023fc1e90269385/pkg/og/structs/flamebearer/flamebearer.go#L85, we currently hard code the value: https://github.com/grafana/pyroscope/blob/9bc2847e6b2e24a09f85b3511023fc1e90269385/pkg/model/flamegraph.go#L128 While the older version of flamebearer calculated it from PeriodDuration: https://github.com/grafana/pyroscope/blob/9bc2847e6b2e24a09f85b3511023fc1e90269385/pkg/og/structs/flamebearer/convert/convert.go#L199-L204 In...

#### Is your feature request related to a problem? Please describe. The UI currently derives the functions TOP table from the flame graph. As a result of truncation happening on...