swagger-to-PDF icon indicating copy to clipboard operation
swagger-to-PDF copied to clipboard

Weird extra info in code 200 response documentation

Open jv42 opened this issue 7 years ago • 6 comments

For all my endpoints, I have a weird superfluous block "Other schema item: [object Object]" in the PDF which is not visible in Swagger-UI:

image

vs

image

Here is the corresponding JSON:

"consumes":[],"produces":["application/json","text/json","application/xml","text/xml"],"responses":{"200":{"description":"OK","schema":{"type":"string"}}}}},

My first documented endpoint returns an array of strings FWIW. It looks like this:

image

vs

image

which still feels wrong.

I can send you my whole JSON file if needed and I'd be happy to help debug the issue as much as I can.

jv42 avatar Mar 08 '17 16:03 jv42

@jv42 please send me the file and I'll debug this side ([email protected]) else we can work on this together. Either option is cool from my side.

simonstewart avatar Mar 08 '17 16:03 simonstewart

I've sent the whole file by email.

jv42 avatar Mar 09 '17 10:03 jv42

I've created a PR #21 with a fix. The fix is acceptable for me, but might break some use cases.

jv42 avatar Mar 15 '17 17:03 jv42

Ah, I've missed a case, which is broken even for me :) I will fix this too and produce a new PR/add to my PR.

jv42 avatar Mar 16 '17 14:03 jv42

Argh, I've totally messed up my pull request, it contains all my changes, instead of just the two commits needed for this issue, sorry about that. I think I'll need to create another fork to fix that, except if you can somehow cherry pick the two commits.

jv42 avatar Mar 16 '17 14:03 jv42

Ok I've destroyed and re-created my fork, then made a new PR #22. Sorry for the mess!

I'll make other PRs for other stuff, as it should be.

jv42 avatar Mar 16 '17 15:03 jv42