Simon Schaufelberger

Results 236 comments of Simon Schaufelberger

I think option 1 is the easier and better solution here.

This is mostly blocked by Rector itself as Rector itself is not compatible with nikic/php-parser v5, see https://github.com/rectorphp/rector/issues/8567

I'm affected by `$frontendUserAuthentication->createSessionId()` and this code is also used in other extensions most likely.

partially yes but the main issue is that setting the id is also deprecated and only done with a magic method as the id is protected. The core team really...

@samsonasik Dear Abdul, this is probably the most difficult Rector rule ever you have seen so far because I not only need to change code within a file but across...

@samsonasik thank you very much for looking into it bit even with this change the problem still exists that the output is currently still the duplicate of `tools_toolsmaintenance` instead of...

I'm merging the two arrays here: https://github.com/sabbelasichon/typo3-rector/pull/4243/files#diff-6659bbad2dc4a8d574769de61529b6e6d9387889d39813bbe2f246c873ba3bfeR461 When you inspect the code afterwards, it looks correct but the generated code is not correct and that is strange. Is there somebody...

The changelog says DI should be used but this is probably super difficult to implement as DI doesn't work out of the box in many scenarios.

I can confirm that. Disabling with ``c::set('MinifyHTML', false);`` doesn't work.

This is how I have it set up, which is totally fine for me (I only need to adjust the greeting if the email goes to more than one person,...