Simon Sabin

Results 32 comments of Simon Sabin

I'd like to be able to run this rule on builds. Largely because uncovering bugs due to use of externally defined variables is really hard. Agree not by default but...

The random thing is that dacfx picks the first column in the table to create the clustered index on, even if thats nullable. In our recent case we also had...

How fragile/hacky is doing this ` $____Pester.CurrentTest.Name`

Got to say that this is frustrating. I've put in code to check if you are the top AST, to avoid this. But thats a hack.

Its a year since this has been commented. Has anyone started this, seems a quick thing.

Whatever you get with the service. We changed a proc and added optional parameters and the service died. Simon Sabin ________________________________ From: Sean Leonard ***@***.***> Sent: Tuesday, March 26, 2024...

Thats a massive problem as there is no way to deploy the change without breaking the system. Which ever is deployed first, DAB or DB, the result is DAB fails...

I believe this should be removed https://github.com/Azure/data-api-builder/blob/689c3e7affe5b94d3ea5d7452c49235068e42652/src/Core/Resolvers/Sql%20Query%20Structures/SqlExecuteQueryStructure.cs#L71 or some configuration to remove it. Sure there is value at design time if the configuration hasn't been setup correctly to provide a...

That as well then. I'd do a PR but think this needs a discussion on whether its by default or configurable.