rust-fitsio

rust-fitsio copied to clipboard

impl fitsio::tables::ReadsCol for OSString

7

Hello, I've had the misfortune of encountering a fits file in which random non-utf8 junk bytes are present after a null byte in a string column. Because fitsio impls ReadsCol...

d3v-null

I have added a function `write_key_cmt` to allow the addition of comments along with the key.

sunipkm

Unaligned Pointer Read

6

This test using a i8 results in an unaligned pointer read... https://github.com/simonrw/rust-fitsio/blob/1972db698dac94440f11e201eccbebe95ec9dace/fitsio/src/headers.rs#L246 ... due to ``` &value as *const $t as *mut c_void, ``` ... in the below. https://github.com/simonrw/rust-fitsio/blob/1972db698dac94440f11e201eccbebe95ec9dace/fitsio/src/headers.rs#L102-L125 Which...

petesmc

release: fitsio-sys v0.5.3

1

This is a release PR for version **0.5.3**. **Use a merge commit.** **To trigger builds initially, close and then immediately re-open this PR once.**

simonrw

Then we don't have to keep the bindings up to date as much

simonrw

Then make safe? Trouble is keeping it up to date with upstream

simonrw

Allow usage of a provided buffer

1

Closes #238

simonrw

The caller may wish to provide their own buffer for better reuse of memory.

simonrw

https://github.com/mstorsjo/msvc-wine/blob/master/README.md ??

simonrw

msys2 cannot find cfitsio version

12

Build under msys is broken: ``` error: failed to run custom build command for `fitsio-sys v0.5.0` Caused by: process didn't exit successfully: `D:\rust\live_stacking\target\debug\build\fitsio-sys-58e5685ff357160f\build-script-build` (exit code: 101) --- stdout cargo:rerun-if-env-changed=CFITSIO >=...

simonrw