Simon Walker

Results 90 comments of Simon Walker

@art-den how did your tests go? For transparency, the reason I haven't released this feature is (assuming it's working) I'd like to build and test on Windows in the CI...

@art-den Sorry but unfortunately I haven't merged the MR yet. I spent some time trying to get windows CI tests running, but I was not able to. I will probably...

@art-den can you try with `fitsio` version `0.20.0`? I've just pushed to [crates.io](https://crates.io/crates/fitsio)

You're absolutely right - confirmed with this `cfitsio` program: ```c #include #include int main() { fitsfile *fptr = NULL; int status = 0; const char *filename = "../examples/M_27_Light_30_secs_2022-06-29T00-53-28_024.fits"; if (fits_open_file(&fptr,...

It looks like it's only reading i32 values from the header that is broken. Looking through the docs, I see the name of the `cfitsio` function that reads an integer...

> > You're absolutely right - confirmed with this `cfitsio` program: > > What is you result? Mine is Ok > > ``` > Got float value 200.000000, int value...

Annoyingly I can't mark the `read_key::` and `read_key::` methods as deprecated, because annotating trait impls is not supported :(

@cjordan @art-den: are either of you reading header values as `i32` or `f32` much? I'm going to remove the ability to read as these types going forward, but want to...

@cjordan what are you weary about with cfitsio's reading of f42s? I might just fix i32 reading, since it may be more convenient for the user if they do 32-bit...

Looks like I removed the `f32` and `i32` header card reading in #170 so I'll close this issue. Thanks for your input!