hledger
hledger copied to clipboard
simonmichael
Request for comment: brick EventM API changes
I'm working on an overhaul of brick's EventM API and I'd love to get your feedback on how it might impact this project. Please see the details and post comments on https://github.com/jtdaugherty/brick/issues/379. Thanks!
Discussion continues at https://github.com/jtdaugherty/brick/issues/379.
Note some general design discussion, possibly useful for us, beginning here.
Hi, folks - Brick 1.0 is out. Here are the details: https://github.com/jtdaugherty/brick/blob/master/CHANGELOG.md#10
Hi @jtdaugherty, I'm having trouble porting code involving handleEditorEvent, which uses a different state type than the main handler. Would you have any clues handy ? Eg in code like:
case mode of
Minibuffer _ ed ->
case ev of
VtyEvent (EvKey KEsc []) -> put $ closeMinibuffer ui
VtyEvent ev -> do
ed' <- handleEditorEvent (VtyEvent ev) ed
put ui{aMode=Minibuffer "filter" ed'}
should I be using runState to run an inner computation updating ed ?
Ha never mind, re-reading the excellent migration notes will help.
VtyEvent ev -> do
ed' <- nestEventM' ed $ handleEditorEvent (VtyEvent ev)
put ui{aMode=Minibuffer "filter" ed'}
Great, I’m glad you got it sorted out. Let me know if anything else comes up!
On Aug 17, 2022, at 1:10 AM, Simon Michael @.***> wrote:
Ha never mind, re-reading the excellent migration notes will help.
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.
We now use and require brick 1.0 (cf #1919). (This means that hledger 1.27 won't get into stackage nightly until brick 1.0 does.)