Simon MᶜKenzie
Simon MᶜKenzie
> as for the IntPR -> nint problem, that might require special handling. The types are taken from the compiler, I do not know why it's falling back to nint....
Getting the `IsUnsafe` flag looks difficult - I had a bit of a look, and I can see that it's present in `method.ConstructedFrom.UnderlyingMethodSymbol.InUnsafe`, but it's all internal. I don't see...
> similarly, I've noticed that it doesn't support the `params` keyword either. Not sure if it can be resolved in the same PR or if it would need to be...
That's an interesting one @OhRickCode! It stems from the fact that the interfaces are built independently, and their full names aren't known until _after_ they've been built. The core independence...
> I have only written one IIncrementalGenerator, so my knowledge is fairly basic, but could you not simply copy the Usings from the concrete class to the interface? (It is...
I'm planning to have a look at this next week.
I spent a bit of time looking at this today, and it's harder than I expected - the generator uses [`ISymbol.ToDisplayString`](https://learn.microsoft.com/dotnet/api/microsoft.codeanalysis.isymbol.todisplaystring) on the `ISymbol` instances to produce the string representation...
This is ready for review again - I just had a last minute refactoring idea :)
Not a problem @ChristianSauer. I hope to get this done next week.
Hi @ChristianSauer, I've rebased the branch on master, but happy to get the other PR merged first, then I can rebase and refactor again, as I think I should probably...