Simon Lin
Simon Lin
Should assign to @wgtdkp ?
> This is a rather big change in the behavior and impacts a lot of use-cases/tests. > > I understand it's desired to move in this direction but I feel...
> I'm OK with adding the config flag if it's too big to fully change all tests. Actually I don't think it's a good idea to introduce another configuration just...
> I think one way is to split them into 2 PRs, one to make tests compatible, the other to do the behavior change. If anything goes wrong we can...
Should we fix this in the same way as https://github.com/openthread/openthread/pull/6474 ? @bukepo @abtink @jwhui
> these two macros seems to be private. And ftd and mtd generates different link libraries, so the app build files have to specify linking to ftd or mtd, and...
Technically speaking, this issue of wrong codecov reporting is not resolved yet. Should we keep it open until the actual codecov dropping issue is resolved? @jinran-google @jwhui
SGTM as long as no addition to code size. :+1:
Retrying discovery requests for multiple times seems quite reasonable. What about using a configuration macro (e.g. `#define OPENTHREAD_CONFIG_DISCOVERY_REQUEST_RETRY 1`) instead of adding another OpenThread API. This is similar to other...
I think there is a difference between retries of Discovery Request and retries of the whole joining process. My personal preference would be using configuration macro for the former and...