prettier-plugin-organize-imports icon indicating copy to clipboard operation
prettier-plugin-organize-imports copied to clipboard

feat: upgrade volar

Open so1ve opened this issue 4 months ago • 13 comments

resolve #98

so1ve avatar Feb 27 '24 08:02 so1ve

@simonhaenisch I didn't looked into the code, so feel free to make a code review before merging 🙂

Shinigami92 avatar Feb 27 '24 09:02 Shinigami92

I also didn't need to install npm i --save-dev @vue/language-core 🤷 But maybe because on of the packages inside the monorepo uses Vue and so when I go into that package it shows pnpm why @vue/language-core:

devDependencies:
vite-plugin-dts 3.7.3
├── @vue/language-core 1.8.27
└─┬ vue-tsc 1.8.27
  └── @vue/language-core 1.8.27
vue-tsc 1.8.27
└── @vue/language-core 1.8.27

Shinigami92 avatar Feb 27 '24 09:02 Shinigami92

@simonhaenisch what's the state? did you have time yet to make a review?

Shinigami92 avatar Mar 04 '24 08:03 Shinigami92

bump on this one @simonhaenisch looking forward to dropping @volar/vue-typescript from our deps. Not sure there is anything I can do to help push it along, and I do understand "I'm to busy" is a likely answer.

aphex avatar Apr 05 '24 19:04 aphex

Sorry and thanks for the pings... kinda forgot about it, i'll try to get it done this week.

simonhaenisch avatar Apr 08 '24 09:04 simonhaenisch

Volar just released v2, shall we upgrade it?

so1ve avatar Apr 08 '24 10:04 so1ve

Yes please, let's get the breaking changes all done at once (:

@so1ve do you have time to update your PR?

simonhaenisch avatar Apr 10 '24 08:04 simonhaenisch

Sure, I'll work on it

so1ve avatar Apr 10 '24 08:04 so1ve

Sure, I'll work on it

@so1ve What's the progress?

Shinigami92 avatar Apr 17 '24 07:04 Shinigami92

Sorry, but there are a few bugs that I had to work on, such as inaccurate text edit positions 😓

so1ve avatar Apr 17 '24 09:04 so1ve

Sorry, but there are a few bugs that I had to work on, such as inaccurate text edit positions 😓

Can I help somehow?

Shinigami92 avatar Apr 17 '24 10:04 Shinigami92

Checking back in on this one. @so1ve I see some code landed a week ago, though labeled WIP so maybe there is more to be done before this all gets considered? If there is help needed let me know, even if it is just testing. Just would need some steps.

aphex avatar May 14 '24 15:05 aphex

Oh I figured it out it is caused by tabs 😅 For some reasons volar incorrectly calculates tab character's width

so1ve avatar May 16 '24 04:05 so1ve

@so1ve @simonhaenisch friendly bump

what are the remaining steps to get this released?

mesqueeb avatar May 23 '24 01:05 mesqueeb