prettier-plugin-organize-imports
prettier-plugin-organize-imports copied to clipboard
feat: upgrade volar
resolve #98
@simonhaenisch I didn't looked into the code, so feel free to make a code review before merging 🙂
I also didn't need to install npm i --save-dev @vue/language-core
🤷
But maybe because on of the packages inside the monorepo uses Vue and so when I go into that package it shows pnpm why @vue/language-core
:
devDependencies:
vite-plugin-dts 3.7.3
├── @vue/language-core 1.8.27
└─┬ vue-tsc 1.8.27
└── @vue/language-core 1.8.27
vue-tsc 1.8.27
└── @vue/language-core 1.8.27
@simonhaenisch what's the state? did you have time yet to make a review?
bump on this one @simonhaenisch looking forward to dropping @volar/vue-typescript
from our deps. Not sure there is anything I can do to help push it along, and I do understand "I'm to busy" is a likely answer.
Sorry and thanks for the pings... kinda forgot about it, i'll try to get it done this week.
Volar just released v2, shall we upgrade it?
Yes please, let's get the breaking changes all done at once (:
@so1ve do you have time to update your PR?
Sure, I'll work on it
Sure, I'll work on it
@so1ve What's the progress?
Sorry, but there are a few bugs that I had to work on, such as inaccurate text edit positions 😓
Sorry, but there are a few bugs that I had to work on, such as inaccurate text edit positions 😓
Can I help somehow?
Checking back in on this one. @so1ve I see some code landed a week ago, though labeled WIP so maybe there is more to be done before this all gets considered? If there is help needed let me know, even if it is just testing. Just would need some steps.
Oh I figured it out it is caused by tabs 😅 For some reasons volar incorrectly calculates tab character's width
@so1ve @simonhaenisch friendly bump
what are the remaining steps to get this released?