angular-http-server icon indicating copy to clipboard operation
angular-http-server copied to clipboard

Enable compression

Open oderayi opened this issue 6 years ago • 12 comments
trafficstars

Would be nice to have a switch to enable compression.

I'm using this to test my Angular production build and auditing via Lighthouse. Compression seems to be the major bottleneck for performance rating.

oderayi avatar Jan 03 '19 09:01 oderayi

A PR for this would be welcome

simonh1000 avatar Jan 03 '19 12:01 simonh1000

Hi @simonh1000 , please expect my PR soon.

oderayi avatar Jan 04 '19 10:01 oderayi

@oderayi are you still working on this? The goal is to support gzip right?

joaosousafranco avatar Aug 05 '19 10:08 joaosousafranco

@joaosousafranco face palm moment. My apologies guys - I have the update on a local fork but I haven't got the time to refactor it into a "PR-ready" state yet. Yes the goal is to support gzip.

oderayi avatar Aug 09 '19 10:08 oderayi

@simonh1000 @joaosousafranco So I just filed my PR for the update. Hope it gets merged soon.

oderayi avatar Aug 10 '19 14:08 oderayi

@joaosousafranco can you try testing it as well

simonh1000 avatar Aug 10 '19 16:08 simonh1000

looks ok

joaosousafranco avatar Sep 04 '19 14:09 joaosousafranco

any update on this guys? would be very helpful if this gets pushed to next release. :)

joboyx avatar Apr 02 '20 05:04 joboyx

Just a couple of questions for the author and we'll be good to go. Interested in what the use cases were though for this - just to repeat this is NOT a production server

simonh1000 avatar Apr 10 '20 09:04 simonh1000

Any updates? 🙂

haskelcurry avatar Feb 18 '22 15:02 haskelcurry

the pr is in review

simonh1000 avatar Feb 19 '22 11:02 simonh1000

This PR is taking 3 years to be reviewed/merged ??

AhmedBenyahia avatar Jul 18 '22 10:07 AhmedBenyahia