Simone Corsi comments

Results 62 comments of


                                            Simone Corsi

Allow to pass a custom sampler instance

is this closed?

Add automated labeling of PR

reference: https://github.com/fastify/fastify/blob/main/.github/labeler.yml

chore(deps): bump @dnlup/doc from 3.1.0 to 4.0.1

@dnlup Are there any breaking changes for us ?

chore(deps): bump @dnlup/doc from 3.1.0 to 4.0.1

> The tests are failing for other reasons. I'll fix that. No tests are failings, I just wanted to know if there are any breaking changes in the major of...

Add the possibity to track a time execution of async functions

I've missed a point in this that I haven't thought before and there is only one thing to keep in mind, this will never be a 100% correct timing. Because...

Add the possibity to track a time execution of async functions

If your callback ends up down in the queue you would have all the overhead in timing of the others, it's something I would want to know if it can...

Feat timing utils

SGTM overall 🚀 Really good job! I'm just having some doubt about `PerformanceObserver` we can talk about that on-call is easier 💪

Test that the package is packed correctly before publishing

What kind of problem are we trying to avoid?

Test that the package is packed correctly before publishing

Ok but then you would have to remember to include new files in the script that checks for them, we could forget that too!

Test that the package is packed correctly before publishing

I never had the need for this kind of check! If you think it may be useful I have no strong opinion about 😄