simone viozzi

Results 38 comments of simone viozzi

mh, funny. The rename part does work: ```python fs.mv('root/tmp/a.pdf', 'root/tmp/b.pdf') ``` but the move part does not. Even if i change the parent array, the `Upload` method will call `_FilesPatch`...

Ok, now it does work. both rename / move and rename and move at the same time. i changed: ```python file1["parents"].append({"id": file2_parent_id}) ``` to: ```python file1["parents"] = [{"id": file2_parent_id}] ```...

I also discovered that we don't need to use `_FilesPatch`, but `_FilesUpdate` can also rename the file. Please take a look at the code, for a single file it should...

> > i don't know if it's ok to just reset the parents array, on a normal drive it's not allowed to have a folder with multiple parents but in...

The way it works right now you always need to specify the target name. @shcheklein is this the same behavior as before? Also the recursive part does not need almost...

@shcheklein how you want to handle `recursive` and `maxdepth`? Right now is recursive by default, I think we can add a check so if the source is a folder and...

Hey @shcheklein could you please review this PR? I think it's ready to be merged

@shcheklein there is already a test: https://github.com/iterative/PyDrive2/blob/688459b9c70c2e398b6dcf6178217f80ef76ee78/pydrive2/test/test_fs.py#L90

@shcheklein regarding the recursive behavior, there is no actual need of recursion. If we change the parent of a folder, all the subfolders will still point to the same id....

> > @shcheklein there is already a test: > > https://github.com/iterative/PyDrive2/blob/688459b9c70c2e398b6dcf6178217f80ef76ee78/pydrive2/test/test_fs.py#L90 > > Q: How did it work before if mv was not implemented? Before `mv` was implemented with `copy`...