generator-maryo icon indicating copy to clipboard operation
generator-maryo copied to clipboard

JSLint settings incorrect - grunt doesn't build on default settings

Open odbol opened this issue 11 years ago • 1 comments

npm install generator-maryo
yo maryo

    _-----_
    |       |
    |--(o)--|   .--------------------------.
   `---------´  |    Welcome to Yeoman,    |
    ( _´U`_ )   |   ladies and gentlemen!  |
    /___A___\   '__________________________'
     |  ~  |
   __'.___.'__
 ´   `  |° ´ Y `
Let's dance with Marionette.


[?] Which style format would you like to use (css/sass/less)? sass
[?] Which template library would you like to use (_/dust)? mustache
[?] Which test framework would you like to use (none/jasmine/mocha)? mocha
[?] Would you like to include Twitter Bootstrap (y)? No


yo maryo:item-view testView
grunt

Gives:

...
14:C5] E007: Missing "use strict" statement.
    App.start();
[L22:C27] W109: Strings must use singlequote.
    $(document).on("click", "a:not([data-bypass])", function (e) {
[L22:C51] W109: Strings must use singlequote.
    $(document).on("click", "a:not([data-bypass])", function (e) {
[L25:C17] W015: Expected 'prop' to have an indentation at 11 instead at 17.
                prop: $(this).prop("href"),
[L25:C42] W109: Strings must use singlequote.
                prop: $(this).prop("href"),
[L26:C17] W015: Expected 'attr' to have an indentation at 11 instead at 17.
                attr: $(this).attr("href")
[L26:C42] W109: Strings must use singlequote.
                attr: $(this).attr("href")
[L27:C13] W015: Expected '}' to have an indentation at 9 instead at 13.
            },
[L28:C44] W109: Strings must use singlequote.
            root = location.protocol + "//" + location.host + App.root;
[L32:C13] W015: Expected 'e' to have an indentation at 11 instead at 13.
            e.preventDefault();
[L33:C13] W015: Expected 'Backbone' to have an indentation at 11 instead at 13.
            Backbone.history.navigate(href.attr, true);
[L35:C5] W015: Expected '}' to have an indentation at 7 instead at 5.
    });
[L37:C27] W109: Strings must use singlequote.
    $(document).on("click", "a[data-bypass]", function (e) {
[L37:C45] W109: Strings must use singlequote.
    $(document).on("click", "a[data-bypass]", function (e) {
[L39:C5] W015: Expected '}' to have an indentation at 7 instead at 5.
    });
[L41:C1] W015: Expected '}' to have an indentation at 3 instead at 1.
});
[L22:C7] W117: 'document' is not defined.
    $(document).on("click", "a:not([data-bypass])", function (e) {
[L28:C20] W117: 'location' is not defined.
            root = location.protocol + "//" + location.host + App.root;
[L28:C47] W117: 'location' is not defined.
            root = location.protocol + "//" + location.host + App.root;
[L37:C7] W117: 'document' is not defined.
    $(document).on("click", "a[data-bypass]", function (e) {

Linting app/scripts/views/SensorMeterView.js...ERROR
[L4:C1] W015: Expected ']' to have an indentation at 3 instead at 1.
],
[L8:C5] E007: Missing "use strict" statement.
    return Backbone.Marionette.ItemView.extend({
[L16:C5] W015: Expected '}' to have an indentation at 7 instead at 5.
    });
[L17:C1] W015: Expected '}' to have an indentation at 3 instead at 1.
});
[L1:C1] W117: 'define' is not defined.
define([
[L6:C31] W098: 'Marionette' is defined but never used.
function (Backbone, Marionette) {

Warning: Task "jshint:all" failed. Use --force to continue.

The generated code does not conform to the linter's settings. You should make the lint setting less strict, or fix the generated code. Otherwise, this is a great project! Keep up the good work!

odbol avatar Jan 29 '14 18:01 odbol

Hi, I've been overseas for a few weeks, so apologies for the delays. I'll change the linters settings. That way people can choose to be more strict if they so desire.

simonblee avatar Feb 23 '14 20:02 simonblee