sist2 icon indicating copy to clipboard operation
sist2 copied to clipboard

sist2 web UI localization

Open simon987 opened this issue 2 years ago • 16 comments

Reply to this issue if you would like to help me add more languages for the sist2 web UI!

The currently supported languages are:

  • en English
  • fr French
  • zh-CN Simplified Chinese
  • de German
  • pl Polish

simon987 avatar Sep 04 '21 13:09 simon987

I can help

panekj avatar Sep 05 '21 15:09 panekj

@panekj Great!

Could you create a new language in https://github.com/simon987/sist2/blob/master/sist2-vue/src/i18n/messages.ts ?. You can use the pl key for Polish. The message names and correspondence in English should be pretty self-explanatory but let me know if there are any ambiguities!

simon987 avatar Sep 05 '21 17:09 simon987

I can do zh-CN (with localized food terms of course :D).

yatli avatar Jan 07 '22 17:01 yatli

I can do zh-CN.

That would be awesome!

If you want to test the changes in the web app, you can run sist2 web with the --dev argument in the root folder of the repository while sist2-vue/watch.sh (after running npm install inside sist2-vue) is running and it should update without needing to (re)compile the C binary. Let me know if you have any problems with that

simon987 avatar Jan 07 '22 17:01 simon987

ooh, that's good to know!

yatli avatar Jan 07 '22 17:01 yatli

@simon987 npm install not working due to fslightbox-vue dep path hard-coded

yatli avatar Jan 20 '22 15:01 yatli

npm install not working due to fslightbox-vue dep path hard-coded

Oh, right... I'm using the fslightbox-vue pro version. I don't really know any good alternatives that's why I'm using it. For now if you want to compile the web UI send me your email I can just send you the link to the tarball

simon987 avatar Jan 20 '22 16:01 simon987

Thanks, ./watch.sh with human in the loop would be too obtrusive for you tho :D

Guess I can just remove it from package.json and remove the lightbox component...

yatli avatar Jan 20 '22 16:01 yatli

Yeah I forgot about this library. In the next version I will try to use NPM's optionalDependencies thing and gracefully disable the lightbox component when it detects that the library is not installed. Ideally I should move away from fslightbox altogether but I really haven't found a good alternative that works with mobile clients yet

simon987 avatar Jan 20 '22 16:01 simon987

Actually just remove the pro version and then npm install --save fslightbox-vue and it compiles fine. You'll only need to compile it once someone's code is checked in.

yatli avatar Jan 20 '22 16:01 yatli

@simon987 Is the topic of Polish translation dead? I can't see it in the actual application. I can provide such translation if you still don't have it, just let me know.

BTW: I would really like to see OCR language pre-installed in default Docker image for Polish as well.

MarioSob avatar May 10 '23 10:05 MarioSob

I can provide such translation if you still don't have it, just let me know.

We don't have polish yet feel free to create a PR for this ! :heart:

OCR language pre-installed in default Docker image for Polish as well

Sure! You can create a separate PR for this by changing this command here: https://github.com/simon987/sist2/blob/master/Dockerfile#L37 for both Dockerfiles

simon987 avatar May 10 '23 12:05 simon987

I have no rights to push my custom branch with changes to your repo: Permission to simon987/sist2.git denied to MarioSob. fatal: unable to access 'https://github.com/simon987/sist2.git/': The requested URL returned error: 403

MarioSob avatar May 10 '23 20:05 MarioSob

That's okay, you can create a fork under your account and try again with https://github.com/MarioSob/sist2 instead

If that doesn't work you can also just email me the modified messages.ts file at [email protected] or paste them here

simon987 avatar May 10 '23 20:05 simon987

I've send you an email.

MarioSob avatar May 11 '23 07:05 MarioSob

Much appreciated @MarioSob. I added the changes in https://github.com/simon987/sist2/commit/41ef94062347f5394f62d675987247d31b3923a4

simon987 avatar May 18 '23 23:05 simon987