gmusicapi icon indicating copy to clipboard operation
gmusicapi copied to clipboard

Published 20 hours ago • verified publisher icon simon-weber

Replace deprecated validictory with fastest fastjsonschema module

Open M0Rf30 opened this issue 5 years ago • 3 comments
trafficstars

Hi with this PR I want to propose a replacement for the deprecated validictory module. fastjsonschema module seems to be faster than jsonschema module too. Thanks for this amazing project

M0Rf30 avatar Nov 30 '19 22:11 M0Rf30

This looks reasonable; thanks. I'll probably wait to integrate it until after the new year so that we can just drop python 2 support at the same time.

simon-weber avatar Dec 01 '19 18:12 simon-weber

As I just packaged gmusicapi in Debian, I'd prefer it if e.g. jsonschema was used instead, as that is already packaged in Debian, while fastjsonschema isn't.

jodal avatar Jan 01 '20 14:01 jodal

As I just packaged gmusicapi in Debian, I'd prefer it if e.g. jsonschema was used instead, as that is already packaged in Debian, while fastjsonschema isn't.

Sure, that's fine with me.

simon-weber avatar Jan 09 '20 23:01 simon-weber