gmusicapi icon indicating copy to clipboard operation
gmusicapi copied to clipboard

McListCall item_schema being incorrectly validated

Open thebigmunch opened this issue 9 years ago • 2 comments

It appears that the responses are being successfully validated no matter if the item_schema matches or not. While testing this, I changed the item_schema of ListTracks to sj_station and ran Mobileclient.get_all_songs() without a ValidationException occurring.

There could be a number of schema changes that have been missed due to this bug. E.g. I found 15 or so changes/additions that needed to be made to sj_track after taking a closer look.

thebigmunch avatar Sep 01 '16 00:09 thebigmunch

Nice find. I took a quick look through the history and have no clue what could have caused this (assuming that it worked at some point, which might not even be true?).

simon-weber avatar Sep 01 '16 00:09 simon-weber

I took a quick look through validation-related issues, and they all appear to be from McCalls, not McListCalls. So it's entirely possible that it may not have ever worked properly. And all the changes/additions to sj_track were needed for ListTracks, not GetStoreTrack, which tracks with that possibility.

thebigmunch avatar Sep 01 '16 00:09 thebigmunch