Finish migrating drift_dev to element2.

Open stereotype441 opened this issue 9 months ago • 4 comments

This change fixes several uses of the old analyzer element model that are internal to drift_dev so that they now use the new element model.

There should be no functional change.

Mar 25 '25 17:03 stereotype441

@simolus3 would you mind reviewing this?

I'm not sure why there is a check failure; I don't think it's related to this PR.

Mar 25 '25 17:03 stereotype441

Thanks, I'll take a look 👍

I don't think we'll get the CI green here, it has to pull packages from pub and most of the build / source_gen dependencies haven't been released yet. I still see lots of failing tests in drift_dev with these changes, I'll see what I can do about them and then I'll merge it into element2 so that you could use that as an upstream target.

Mar 25 '25 19:03 simolus3

I have applied your changes in e9c1db1233b376b2c9ed30a4e303c9eb33805635. Didn't get all tests to pass today, but I think drift_dev is in a state where it should mostly work now.

Mar 25 '25 19:03 simolus3

I have applied your changes in e9c1db1. Didn't get all tests to pass today, but I think drift_dev is in a state where it should mostly work now.

Great, thank you! And thanks for the fixes.

Mar 25 '25 23:03 stereotype441

These changes have since been cherry-picked onto element2 and later develop.

Jul 18 '25 20:07 simolus3