Mikael Korpela

Results 341 comments of Mikael Korpela

@edanzer it's the right kind of nit-picky, thanks! :-)

> Things that are a bit odd with this PR. Placeholders. > the native date picker doesn't support placeholders. > We could hack with JS but wanted to discuss it...

Let's use just "Browser" as style name to make sure the copy shows up entirely.

Let's optimize for majority (newsletter subscriptions) and not minority.

> Labels > How are labels currently used? I had an assumption, that they would be reflected/change in the editor UI (like page break), but it changed only the list...

FYI I've learned that we should probably support something called ["block gap"](https://developer.wordpress.org/block-editor/how-to-guides/themes/global-settings-and-styles/#what-is-blockgap-and-how-can-i-use-it) via something like `var(--wp--style--block-gap, 1.5rem)` for spacing between inner blocks such as progress, step container and buttons. 🤔

Todo: - Enej's feedback above; might make sense to separate a simple direct link to its own PR as that's more straightforward - Check with Ilona on designs/copy

> It could help to bring users back to Jetpack Forms dashboard. I think it's fine if we keep them in the emails, and just make the experience in email...

Not a blocker for merging but @ilonagl thoughts on button colour? Jetpack green vs WP.com blueberry vs black?

@scruffian @richtabor the WP.com custom modal could now be removed since sidebar version merged in Gutenberg? https://github.com/WordPress/gutenberg/pull/66836