Simon Hanna

Results 55 comments of Simon Hanna

```javascript let pod: V1Pod; console.log(pod.metadata?.creationTimestamp, typeof pod.metadata?.creationTimestamp); ``` outputs `2020-07-23T06:01:17Z string` the type of `V1Pod.metadata.creationTimestamp` however is `Date | undefined` and not `string | undefined` Possible solutions are converting the...

@brendanburns could you please re-evaluate this? /remove-lifecycle stale

Would be nice if this gets fixed eventually... /remove-lifecycle stale

for some historic reason our logger implements the Logger class and doesn't extend it. I've pinned our dependencies to an older version for now. I'll see if I can refactor...

yeah. I refactored this. But then again https://github.com/log4js-node/log4js-node/commit/126e286c1a56892f3962a5621e46c8ddf4b41510 was also a change that removed an exported type. I'm currently pinning log4js due to such changes

I mean the missing BaseLayout. Renaming something is like removing it. I have log4js defined as a peer dependency (`^6.0.0`) and such changes break our builds if anyone pulls in...

We took some time to think about our options to accomplish our goal of treating api requests and users differently. We'd be able to do that in our default backend,...

I looked into allowing this, but couldn't get it to work. I don't need it myself, if you want it and can figure out how to get it done, I'll...

Actually primitive types apparently also cause issues. Using a number instead of `undefined` results in the following stacktrace ``` /project/node_modules/inversify/lib/container/container.js:467 throw new Error(ERROR_MSGS.ON_DEACTIVATION_ERROR(constructor.name, ex.message)); ^ Error: onDeactivation() error in class...

I'm happy to contribute to make this work again if it's intended to work with primitive types. If it's not it would be nice to state that somewhere