redshift-plasmoid icon indicating copy to clipboard operation
redshift-plasmoid copied to clipboard

Enhancement request - Brightness setting for day and night

Open jedd opened this issue 10 years ago • 11 comments

Fantastic widget, thanks.

It looks like the brightness value has an effect during day and night periods equally. Would it be feasible to have the brightness value only take effect (via the smooth transition) with the shift to the Night colour temperature? Alternatively have a separate brightness value associated with the Day colour temperature range?

jedd avatar Nov 30 '14 04:11 jedd

Redshift daemon doesn't support this feature. When redshift will support dbus it may be possible. You should ask this feature on the redshift github page because it's more related to the core.

This is not easily implementable from the widget side either because the widget need to restart the daemon every time it wants to change a parameter. This means it cannot make the brightness fade during the day-night switch. By using a brightness value for the day and one for the night the plasmoid should restart the daemon at least once and the user will see the screen going white and than red again with a new brightness, and this is not pleasant.

simgunz avatar Nov 30 '14 18:11 simgunz

Thanks - I was about to raise a ticket on the Redshift repo, but it looks like they already do in fact have this feature?

It's either (on the CLI) the -b xx:yy (xx for day, yy for night, range 0.1 - 1.0), or via the ~/.config/redshift.conf file you can specify it as brightness-day= and brightness-night=

From what I've read, there may be conflicts between trying to use a widget and the redshift conf at the same time?

jedd avatar Dec 01 '14 01:12 jedd

I'm sorry I didn't know about that option (and haven't looked for it before answering you, my fault). In this case it can be added to the plasmoid. I'll do it soon.

On Mon, Dec 1, 2014 at 2:20 AM, Jedd Rashbrooke [email protected] wrote:

Thanks - I was about to raise a ticket on the Redshift repo, but it looks like they already do in fact have this feature?

It's either (on the CLI) the -b xx:yy (xx for day, yy for night, range 0.1 - 1.0), or via the ~/.config/redshift.conf file you can specify it as brightness-day= and brightness-night=

From what I've read, there may be conflicts between trying to use a widget and the redshift conf at the same time?

— Reply to this email directly or view it on GitHub https://github.com/simgunz/redshift-plasmoid/issues/15#issuecomment-65010431 .

simgunz avatar Dec 01 '14 08:12 simgunz

Hey, no problem - I've only just discovered the joys of redshift, and should have looked deeper into the core app to start with. Great result, though, thank you again!

jedd avatar Dec 01 '14 08:12 jedd

What about instead of relying on Redshift to change the brightness, simply use the the BlueDevil (or Battery Monitor) DBUS calls?

silverhook avatar Jan 26 '16 14:01 silverhook

The aim of that setting is to control the brightness parameter of redshift, but actually there is no need to use it at all. Why one should control brightness trough redshift when I can do it trough the battery plasmoid?

I should remove it completely, but some likes it.

simgunz avatar Jan 26 '16 15:01 simgunz

IMHO it might make sense to embed Redshift into the Battery Plasmoid :smile_cat:

On a more serious note, is it actually possible to automatically adjust the brightness according to time inside the Battery Plasmoid?

silverhook avatar Jan 26 '16 17:01 silverhook

What about desktop users? I don't think the Battery Plasmoid works in that case.

Stefan Zecevic The little commuter in the big red scooter

On Tue, Jan 26, 2016 at 9:19 AM, Matija Šuklje [email protected] wrote:

IMHO it might make sense to embed Redshift into the Battery Plasmoid [image: :smile_cat:]

On a more serious note, is it actually possible to automatically adjust the brightness according to time inside the Battery Plasmoid?

— Reply to this email directly or view it on GitHub https://github.com/simgunz/redshift-plasmoid/issues/15#issuecomment-175126065 .

xlegs avatar Jan 26 '16 17:01 xlegs

@xlegs, good point. But then again, the “Battery Plasmoid” seems to be responsible for screen (and keyboard back-light) brightness even on desktops.

silverhook avatar Jan 26 '16 19:01 silverhook

Yes, I use a desktop and laptop, and it's convenient having a single icon / control to flip back to 'raw' screen output in terms of hue and contrast -- for example when working on graphic or photo manipulation after sunset.

jedd avatar Jan 26 '16 22:01 jedd

So what are the proposed changes here? To control the brightness with dbus via redshift, because even tough it can be controlled via battery widget you would lke to have a one-click control to switch between two level of brightness (together with the change of gamma). RIght?

A note: For plasma 5 there is a new applet to control redshift, developed by someone else. So you may need to suggest this also there: http://kde-apps.org/content/show.php/Redshift+Control?content=170746

simgunz avatar Jan 31 '16 08:01 simgunz