svelte-range-slider-pips icon indicating copy to clipboard operation
svelte-range-slider-pips copied to clipboard

[feature] type support

Open ghostdevv opened this issue 3 years ago • 4 comments

Currently there are no types shipped with the package, would be nice to do this

ghostdevv avatar Mar 12 '22 00:03 ghostdevv

In terms of options to auto generate types, you can either stick with the current rollup build system and use sveld to generate types. Or you can switch to sveltekit package and use that to build the package

ghostdevv avatar Mar 12 '22 00:03 ghostdevv

I've created a type definition. You can add it as dev dep. https://www.npmjs.com/package/@types/svelte-range-slider-pips

i7N3 avatar Nov 04 '22 15:11 i7N3

I've created a type definition. You can add it as dev dep. https://www.npmjs.com/package/@types/svelte-range-slider-pips

Thanks @i7N3 ... is this a normal/accepted way to handle the issue? And if so is the issue closable? Or should the types be defined inside the repo?

simeydotme avatar Nov 04 '22 18:11 simeydotme

I've created a type definition. You can add it as dev dep. https://www.npmjs.com/package/@types/svelte-range-slider-pips

Thanks @i7N3 ... is this a normal/accepted way to handle the issue? And if so is the issue closable? Or should the types be defined inside the repo?

As someone mentioned here, there is a better way to rewrite svelte-range-slider-pips to typescript.

i7N3 avatar Nov 05 '22 10:11 i7N3