svelte-range-slider-pips icon indicating copy to clipboard operation
svelte-range-slider-pips copied to clipboard

[docs] Broken links on docs site

Open sortbyfirstname opened this issue 2 years ago • 5 comments

Describe the bug There are some broken links on the docs site.

Sidebar:

  • Pips link within Options does not navigate to the pips prop in the article.
  • Range link within Options does not navigate to the range prop in the article.

Examples:

  • All 'Recipe' style links on the Examples page are broken, resulting in a 404.

Recipes:

  • All 'Recipe' style links on the Recipes page are broken, resulting in a 404.
  • The 'Recipe' style links have broken images.

sortbyfirstname avatar Oct 21 '23 21:10 sortbyfirstname

thank you @sortbyfirstname !! I rushed this out before a vacation / new job and I didn't get a chance to fully QA it. but I deemed it was better than the previous one so just "shipped it" :D

really appreciate the feedback

simeydotme avatar Oct 24 '23 08:10 simeydotme

The PR didn't fix the broken links in the Recipes/Examples landing pages, @sortbyfirstname ... I'll take a deeper look later. There's something weird with the way the base interacts with them

simeydotme avatar Nov 08 '23 09:11 simeydotme

That is weird, sorry about that - "worked on my machine" 😅. I'll admit this was my first time dealing with Astro, will have another look when I get a chance as well.

sortbyfirstname avatar Nov 08 '23 09:11 sortbyfirstname

For the relative links that are broken, I believe it's due to the trailing slash at the end of urls (see https://learn.svelte.dev/tutorial/trailingslash). So the [Read more](./steps-combined) link when a user is on "/example/pips/" sends a link to "/example/pips/steps-combined/" when the intended target to "/example/steps-combined/"

kelvinsjk avatar Aug 01 '24 18:08 kelvinsjk

For the relative links that are broken, I believe it's due to the trailing slash at the end of urls (see https://learn.svelte.dev/tutorial/trailingslash). So the [Read more](./steps-combined) link when a user is on "/example/pips/" sends a link to "/example/pips/steps-combined/" when the intended target to "/example/steps-combined/"

Ah! thanks for this Kelvin, I'll see if this is a solution! I might try to upgrade to a newer version of Astro as well, see if it helps

simeydotme avatar Aug 13 '24 04:08 simeydotme