simde icon indicating copy to clipboard operation
simde copied to clipboard

Remove references to `__riscv_zvlsseg`

Open mr-c opened this issue 2 months ago • 5 comments

Sorry for the archaelogy here. Zvlsseg is an old extension name from pre-1.0 RVV. It was removed from RVV 1.0 and the last several compiler releases never define __riscv_zvlsseg.

Originally posted by @topperc in https://github.com/simd-everywhere/simde/issues/1285#issuecomment-3434625458

mr-c avatar Oct 23 '25 11:10 mr-c

Thank you @topperc for your report; I guess https://github.com/llvm/llvm-project/commit/7a275dc35411b8c3f510166f40c225cd10dc5eec is the relevant commit for LLVM

Given @Ruhung 's PR that added these references in February, I'm guessing there are some vendor forks of clang out there where this check is still relevant. Any advice from either of you on how to move forward?

mr-c avatar Oct 23 '25 12:10 mr-c

@topperc Isn't our existing check flexible enough?

https://github.com/simd-everywhere/simde/blob/9130a9ff26fbc1b68ab64e7c1c1d344f2bdf3ac9/simde/simde-arch.h#L553-L555

mr-c avatar Oct 23 '25 12:10 mr-c

Remove references to __riscv_zvlsseg. #1353

Ruhung avatar Oct 23 '25 13:10 Ruhung

@topperc Isn't our existing check flexible enough?

simde/simde/simde-arch.h

Lines 553 to 555 in 9130a9f

#if defined(__riscv_zvlsseg) || defined(__riscv_v)

define SIMDE_ARCH_RISCV_ZVLSSEG 1

#endif

Maybe I took the title of https://github.com/simd-everywhere/simde/pull/1285 too literally. It says "only when we have __riscv_zvlsseg flag", but that's not what the code did.

topperc avatar Oct 23 '25 15:10 topperc

Shall we leave things as-is to support the older/forked clangs?

mr-c avatar Oct 23 '25 15:10 mr-c