Results 7 comments of Simbarashe Dzinamarira

This pull request is followed up by https://github.com/apache/hadoop/pull/4127

> https://issues.apache.org/jira/browse/HADOOP-13144 > Could we have a HADOOP JIRA just for the changes in commons? It could be something like: https://issues.apache.org/jira/browse/HADOOP-13144 Ok. Moving these to HDFS-16669

Yes, it should be optional. Thanks for spotting the error. I'll fix that. I'm considering making the field a byte array in the client protocol. Only routers need to parse...

Hi @fengnanli could you please take a look and add folks in your team.

@goiri @omalley I've now split off the IPC related parts of this change into another pull request (https://github.com/apache/hadoop/pull/4311). Please take a look. The javadoc issues are unrelated to my change....

Could you fix the new checkstyle issues: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4967/11/artifact/out/results-checkstyle-root.txt

Javadoc issues are beginning worked on in the following two PRs. https://github.com/apache/hadoop/pull/5344 https://github.com/apache/hadoop/pull/5226