simar7

Results 179 comments of simar7

> @simar7 defsec [already checks](https://github.com/aquasecurity/defsec/blob/master/rules/cloud/policies/aws/cloudtrail/enable_all_regions.go) this rule. Yes the plan is to re-write existing Go rules in Rego. As part of this PR, we should also deprecate the Go rules....

hi @SanaaYousaf can you please explain the motivation for this PR? Do we have an issue in the Trivy repo for tracking this?

looks like tests are red, @SanaaYousaf could you look into that?

looks like tests are failing, @SanaaYousaf

> merge conflict resolved. The Meta struct is not present in my branch in the `/pkg/providers/aws/aws.go` file so please confirm it should remain. You have to rebase on latest master...

> rebase complete. Should be good for review now. tests are still red. Could you look into it? Might have to run `go mod tidy` and commit changes, if any.

> `go mod tidy` is giving the following errors: > > ``` > github.com/aquasecurity/defsec/internal/adapters/cloudformation/aws/iamidentitycenter imports > github.com/aquasecurity/defsec/pkg/scanners/cloudformation/parser: no matching versions for query "latest" > github.com/aquasecurity/defsec/internal/adapters/terraform/aws/iamidentitycenter tested by > github.com/aquasecurity/defsec/internal/adapters/terraform/aws/iamidentitycenter.test imports...

> @simar7 Curious if there is any ETA that can be provided on when the new PR can go in? We need these two changes merged before we can merge...

> @simar7 any updates you can provide on ETA for when we can get this PR completed? @gantta defsec and other iac ancillary repos have been merged into trivy. If...